Re: [PATCH v2 2/3] platform: arm64: Add driver for EC found in most X1E laptops

From: Krzysztof Kozlowski
Date: Sun Dec 22 2024 - 01:35:49 EST


On Thu, Dec 19, 2024 at 08:43:16PM +0000, Bryan O'Donoghue wrote:

> > +
> > + val = i2c_smbus_read_byte_data(ec->client, EC_IRQ_REASON_REG);
> > + if (val < 0) {
> > + dev_err(dev, "Failed to get EC IRQ reason: %d\n", val);
> > + return IRQ_HANDLED;
> > + }
> > +
> > + dev_info(dev, "Unhandled EC IRQ reason: %d\n", val);
>
> Should an unhandled IRQ be an info or an err ?

Should be debug or ratelimit at most.

Best regards,
Krzysztof