Re: [PATCH v2 1/3] dt-bindings: platform: Add bindings for Qcom's EC on IT8987

[Krzysztof Kozlowski]

On 22/12/2024 07:33, Krzysztof Kozlowski wrote:
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: qcom,x1e-it8987-ec
> 
> That's not a SoC, so I don't understand:
> 1. referring to the SoC,
> 2. Having this alone and as fallback.
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run 'make dt_binding_check' (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.

BTW, for sure Qualcomm did not develop/create it8987, so it cannot be
used here. Come with specific compatible for this given, one product:
embedded controller on one Lenovo laptop and use it also as filename.

Best regards,
Krzysztof