Re: [PATCH net-next v3 1/5] dt-bindings: net: pcs: Add Ethernet PCS for Qualcomm IPQ9574 SoC

From: Krzysztof Kozlowski
Date: Sun Dec 22 2024 - 03:20:35 EST


On 16/12/2024 14:40, Lei Wei wrote:
> The 'UNIPHY' PCS block in the IPQ9574 SoC includes PCS and SerDes
> functions. It supports different interface modes to enable Ethernet
> MAC connections to different types of external PHYs/switch. It includes
> PCS functions for 1Gbps and 2.5Gbps interface modes and XPCS functions
> for 10Gbps interface modes. There are three UNIPHY (PCS) instances
> in IPQ9574 SoC which provide PCS/XPCS functions to the six Ethernet
> ports.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Lei Wei <quic_leiwei@xxxxxxxxxxx>


Did you add here some properties as well after review was given? Can I
trust this review tag to be matching what was reviewed?

Best regards,
Krzysztof