Re: [PATCH v5 0/3] firmware: add Exynos ACPM protocol driver

[Krzysztof Kozlowski]

On Fri, Dec 20, 2024 at 02:32:50PM +0000, Tudor Ambarus wrote:
> Alive Clock and Power Manager (ACPM) Message Protocol is defined for
> the purpose of communication between the ACPM firmware and masters
> (AP, AOC, ...). ACPM firmware operates on the Active Power Management
> (APM) module that handles overall power activities.
> 
> This protocol driver provides the interface for all the client drivers
> making use of the features offered by the APM. Add ACPM protocol support.
> 
> Changes in v5:
> - depends on:
>   - Link: https://lore.kernel.org/all/20241220-acpm-v4-upstream-mbox-v6-0-a6942806e52a@xxxxxxxxxx/
>   - it uses the newly introduced mbox_request_channel_by_args() API
> - dt-bindings:
>   - drop redundant binding word from the commit subject
>   - remove extra blank line and update example with by complying to
>     #mbox-cells = <0>;
>   - drop Krzysztof's R-b tag as the example was updated.

This does not invalidate review. You just dropped argument from a
phandle, it's not even related to this binding. The format of phandle
depends on provider, not consumer binding.

Best regards,
Krzysztof