Re: [PATCH 4/6] dt-bindings: watchdog: renesas: Document `renesas,r9a09g057-syscon-wdt-errorrst` property

[Krzysztof Kozlowski]

On 22/12/2024 12:11, Lad, Prabhakar wrote:
>>> [0] https://lore.kernel.org/all/20241218003414.490498-6-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
>>
>> Really? I see in rzv2h_wdt_probe():
>>
>> +               if (ret)
>> +                       return ret;
>>
>> so to me you are failing the probe, not skipping anything.
>>
> Yes really this wont break any ABI. From patch [0] we have the below:
> 
> [0] https://lore.kernel.org/all/20241218003414.490498-6-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
> 
>     /* Do not error out to maintain old DT compatibility */
>     syscon = syscon_regmap_lookup_by_phandle(np,
> "renesas,syscon-cpg-error-rst");

Right, somehow I missed that part.

>     if (!IS_ERR(syscon)) {
>         struct of_phandle_args args;
>         u32 reg;
> 
>         ret = of_parse_phandle_with_fixed_args(np,
> "renesas,syscon-cpg-error-rst",
>                                2, 0, &args);
>         if (ret)
>             return ret;
Best regards,
Krzysztof