drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'mbuf_priv' not described in 'msc'
From: kernel test robot
Date: Sun Dec 22 2024 - 20:10:38 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4bbf9020becbfd8fc2c3da790855b7042fad455b
commit: 615c164da0eb42cbfb1688cb429cc4d5039db5d8 intel_th: msu: Introduce buffer interface
date: 5 years ago
config: x86_64-randconfig-071-20241209 (https://download.01.org/0day-ci/archive/20241223/202412230908.tbKuk3Gl-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241223/202412230908.tbKuk3Gl-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412230908.tbKuk3Gl-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/hwtracing/intel_th/msu.c:77: warning: Function parameter or struct member 'msc' not described in 'msc_window'
drivers/hwtracing/intel_th/msu.c:122: warning: bad line:
drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'msu_base' not described in 'msc'
>> drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'mbuf_priv' not described in 'msc'
>> drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'work' not described in 'msc'
drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'iter_list' not described in 'msc'
drivers/hwtracing/intel_th/msu.c:162: warning: Function parameter or struct member 'do_irq' not described in 'msc'
drivers/hwtracing/intel_th/msu.c:1276: warning: Function parameter or struct member 'nr_pages' not described in 'msc_buffer_alloc'
drivers/hwtracing/intel_th/msu.c:1276: warning: Function parameter or struct member 'nr_wins' not described in 'msc_buffer_alloc'
drivers/hwtracing/intel_th/msu.c:1276: warning: Excess function parameter 'size' description in 'msc_buffer_alloc'
vim +162 drivers/hwtracing/intel_th/msu.c
ba82664c134ef7 Alexander Shishkin 2015-09-22 104
ba82664c134ef7 Alexander Shishkin 2015-09-22 105 /**
ba82664c134ef7 Alexander Shishkin 2015-09-22 106 * struct msc - MSC device representation
ba82664c134ef7 Alexander Shishkin 2015-09-22 107 * @reg_base: register window base address
ba82664c134ef7 Alexander Shishkin 2015-09-22 108 * @thdev: intel_th_device pointer
615c164da0eb42 Alexander Shishkin 2019-07-05 109 * @mbuf: MSU buffer, if assigned
615c164da0eb42 Alexander Shishkin 2019-07-05 110 * @mbuf_priv MSU buffer's private data, if @mbuf
ba82664c134ef7 Alexander Shishkin 2015-09-22 111 * @win_list: list of windows in multiblock mode
4e0eaf239fb33e Alexander Shishkin 2019-05-03 112 * @single_sgt: single mode buffer
aad14ad3cf3a63 Alexander Shishkin 2019-05-03 113 * @cur_win: current window
ba82664c134ef7 Alexander Shishkin 2015-09-22 114 * @nr_pages: total number of pages allocated for this buffer
ba82664c134ef7 Alexander Shishkin 2015-09-22 115 * @single_sz: amount of data in single mode
ba82664c134ef7 Alexander Shishkin 2015-09-22 116 * @single_wrap: single mode wrap occurred
ba82664c134ef7 Alexander Shishkin 2015-09-22 117 * @base: buffer's base pointer
ba82664c134ef7 Alexander Shishkin 2015-09-22 118 * @base_addr: buffer's base address
ba82664c134ef7 Alexander Shishkin 2015-09-22 119 * @user_count: number of users of the buffer
ba82664c134ef7 Alexander Shishkin 2015-09-22 120 * @mmap_count: number of mappings
ba82664c134ef7 Alexander Shishkin 2015-09-22 121 * @buf_mutex: mutex to serialize access to buffer-related bits
ba82664c134ef7 Alexander Shishkin 2015-09-22 122
ba82664c134ef7 Alexander Shishkin 2015-09-22 123 * @enabled: MSC is enabled
ba82664c134ef7 Alexander Shishkin 2015-09-22 124 * @wrap: wrapping is enabled
ba82664c134ef7 Alexander Shishkin 2015-09-22 125 * @mode: MSC operating mode
ba82664c134ef7 Alexander Shishkin 2015-09-22 126 * @burst_len: write burst length
ba82664c134ef7 Alexander Shishkin 2015-09-22 127 * @index: number of this MSC in the MSU
ba82664c134ef7 Alexander Shishkin 2015-09-22 128 */
ba82664c134ef7 Alexander Shishkin 2015-09-22 129 struct msc {
ba82664c134ef7 Alexander Shishkin 2015-09-22 130 void __iomem *reg_base;
aac8da65174a35 Alexander Shishkin 2019-05-03 131 void __iomem *msu_base;
ba82664c134ef7 Alexander Shishkin 2015-09-22 132 struct intel_th_device *thdev;
ba82664c134ef7 Alexander Shishkin 2015-09-22 133
615c164da0eb42 Alexander Shishkin 2019-07-05 134 const struct msu_buffer *mbuf;
615c164da0eb42 Alexander Shishkin 2019-07-05 135 void *mbuf_priv;
615c164da0eb42 Alexander Shishkin 2019-07-05 136
615c164da0eb42 Alexander Shishkin 2019-07-05 137 struct work_struct work;
ba82664c134ef7 Alexander Shishkin 2015-09-22 138 struct list_head win_list;
4e0eaf239fb33e Alexander Shishkin 2019-05-03 139 struct sg_table single_sgt;
aad14ad3cf3a63 Alexander Shishkin 2019-05-03 140 struct msc_window *cur_win;
ba82664c134ef7 Alexander Shishkin 2015-09-22 141 unsigned long nr_pages;
ba82664c134ef7 Alexander Shishkin 2015-09-22 142 unsigned long single_sz;
ba82664c134ef7 Alexander Shishkin 2015-09-22 143 unsigned int single_wrap : 1;
ba82664c134ef7 Alexander Shishkin 2015-09-22 144 void *base;
ba82664c134ef7 Alexander Shishkin 2015-09-22 145 dma_addr_t base_addr;
ba82664c134ef7 Alexander Shishkin 2015-09-22 146
ba82664c134ef7 Alexander Shishkin 2015-09-22 147 /* <0: no buffer, 0: no users, >0: active users */
ba82664c134ef7 Alexander Shishkin 2015-09-22 148 atomic_t user_count;
ba82664c134ef7 Alexander Shishkin 2015-09-22 149
ba82664c134ef7 Alexander Shishkin 2015-09-22 150 atomic_t mmap_count;
ba82664c134ef7 Alexander Shishkin 2015-09-22 151 struct mutex buf_mutex;
ba82664c134ef7 Alexander Shishkin 2015-09-22 152
ba82664c134ef7 Alexander Shishkin 2015-09-22 153 struct list_head iter_list;
ba82664c134ef7 Alexander Shishkin 2015-09-22 154
ba82664c134ef7 Alexander Shishkin 2015-09-22 155 /* config */
ba82664c134ef7 Alexander Shishkin 2015-09-22 156 unsigned int enabled : 1,
aac8da65174a35 Alexander Shishkin 2019-05-03 157 wrap : 1,
aac8da65174a35 Alexander Shishkin 2019-05-03 158 do_irq : 1;
ba82664c134ef7 Alexander Shishkin 2015-09-22 159 unsigned int mode;
ba82664c134ef7 Alexander Shishkin 2015-09-22 160 unsigned int burst_len;
ba82664c134ef7 Alexander Shishkin 2015-09-22 161 unsigned int index;
ba82664c134ef7 Alexander Shishkin 2015-09-22 @162 };
ba82664c134ef7 Alexander Shishkin 2015-09-22 163
:::::: The code at line 162 was first introduced by commit
:::::: ba82664c134ef7ab97808f09a3c5e894b0a4900d intel_th: Add Memory Storage Unit driver
:::::: TO: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki