Re: [PATCH V1 1/3] drivers/fpga/amd: Add new driver for AMD Versal PCIe card

From: Yidong Zhang
Date: Sun Dec 22 2024 - 20:53:54 EST




On 11/18/24 23:07, Xu Yilun wrote:

+obj-$(CONFIG_AMD_VERSAL_MGMT) += amd-vmgmt.o
IMHO the naming vmgmt is hard to understand, any better idea?
The "v" stand for Versal. We would change to amd-vpci for Versal based pcie
"v" + "pci" is quite a misleading term, maybe just versal-pci?

Hi Yilun,

I sent the V2 patch and refactored the driver as versal-pci now.
One more thing that I kept in V2 was the firmware_upload. I forgot to
mention that I'd love to switch to the newly proposed interface once
it is ready. I saw the proposal was now as config_fs and it was not merged yet.

Happy Holidays.

Thanks,
David