RE: [PATCH v2 2/3] mfd: syscon: Remove the platform driver support

From: Pankaj Dubey
Date: Sun Dec 22 2024 - 21:13:46 EST




> -----Original Message-----
> From: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Sent: Tuesday, December 17, 2024 11:42 PM
> To: Lee Jones <lee@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Pankaj
> Dubey <pankaj.dubey@xxxxxxxxxxx>; Heiko Stuebner <heiko@xxxxxxxxx>;
> Liviu Dudau <liviu.dudau@xxxxxxx>; Sudeep Holla <sudeep.holla@xxxxxxx>;
> Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> Cc: Peter Griffin <peter.griffin@xxxxxxxxxx>; Will McVicker
> <willmcvicker@xxxxxxxxxx>; John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>;
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH v2 2/3] mfd: syscon: Remove the platform driver support
>
> The platform driver is dead code. It is not used by DT platforms since commit
> bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform devices")
> which said:
>
> For non-DT based platforms, this patch keeps syscon platform driver
> structure so that syscon can be probed and such non-DT based drivers
> can use syscon_regmap_lookup_by_pdev API and access regmap handles.
> Once all users of "syscon_regmap_lookup_by_pdev" migrated to DT based,
> we can completely remove platform driver of syscon, and keep only helper
> functions to get regmap handles.
>
> The last user of syscon_regmap_lookup_by_pdevname() was removed in 2018.
> syscon_regmap_lookup_by_pdevname() was then removed in 2019, but that
> commit failed to remove the rest of the platform driver.
>
> Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---

Reviewed-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>

Tested on arm64: Tesla FSD

Tested-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>

Thanks,
Pankaj Dubey