Re: [PATCH v5] pinctrl: stm32: Add check for clk_enable()

[Mingwei Zheng]

Hi Marek,

On Sun, Dec 15, 2024 at 6:54 PM Marek Vasut <marex@xxxxxxx> wrote:
>
> On 12/15/24 9:40 PM, Mingwei Zheng wrote:
>
> [...]
>
> > @@ -1617,10 +1602,18 @@ int stm32_pctl_probe(struct platform_device *pdev)
> >               return -EINVAL;
> >       }
> >       pctl->banks = devm_kcalloc(dev, banks, sizeof(*pctl->banks),
> > -                     GFP_KERNEL);
> > +                                GFP_KERNEL);
>
> Please drop this one change.

Fixed in PATCH v6.

>
> >       if (!pctl->banks)
> >               return -ENOMEM;
> >
> > +     pctl->clks = devm_kcalloc(dev, banks, sizeof(*pctl->clks),
> > +                               GFP_KERNEL);
> > +     if (!pctl->clks)
> > +             return -ENOMEM;
> > +
> > +     for (i = 0; i < banks; ++i)
> > +             pctl->clks[i].id = "";
>
> Is this ^ assignment necessary ? If so, why ?
>
> [...]

Thanks for pointing this out. We call devm_clk_bulk_get_all in
stm32_pctl_probe() to handle get clk in PATCH v6.

Best,
Mingwei