Re: [PATCH] nvmem: mtk-efuse: Enable GPU speed bin post-processing for MT8188

[AngeloGioacchino Del Regno]

Il 23/12/24 12:24, Chen-Yu Tsai ha scritto:
> On Mon, Dec 23, 2024 at 7:11 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:
> > Il 23/12/24 11:06, Chen-Yu Tsai ha scritto:
> > > Like the MT8186, the MT8188 stores GPU speed binning data in its efuse.
> > > The data needs post-processing into a format that the OPP framework can
> > > use.
> > >
> > > Add a compatible match for MT8188 efuse with post-processing enabled.
> >
> > Let's just change the MT8188 compatible list to
> >
> > compatible = "mediatek,mt8188-efuse", "mediatek,mt8186-efuse";
>
> That would be "mediatek,mt8188-efuse", "mediatek,mt8186-efuse", "mediatek,efuse"
> then?

No, we're dropping the generic "mediatek,efuse".

Cheers!

> Fine by me. :D
>
> ChenYu
>
> > instead :-)
> >
> > Cheers,
> > Angelo
> >
> > > Cc: <stable@xxxxxxxxxxxxxxx>
> > > Fixes: ff1df1886f43 ("dt-bindings: nvmem: mediatek: efuse: Add support for MT8188")
> > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> > > ---
> > >
> > > I'm not exactly sure about pointing to the dt bindings commit for the
> > > fixes tag.
> > > ---
> > >    drivers/nvmem/mtk-efuse.c | 1 +
> > >    1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> > > index af953e1d9230..e8409e1e7fac 100644
> > > --- a/drivers/nvmem/mtk-efuse.c
> > > +++ b/drivers/nvmem/mtk-efuse.c
> > > @@ -112,6 +112,7 @@ static const struct mtk_efuse_pdata mtk_efuse_pdata = {
> > >    static const struct of_device_id mtk_efuse_of_match[] = {
> > >        { .compatible = "mediatek,mt8173-efuse", .data = &mtk_efuse_pdata },
> > >        { .compatible = "mediatek,mt8186-efuse", .data = &mtk_mt8186_efuse_pdata },
> > > +     { .compatible = "mediatek,mt8188-efuse", .data = &mtk_mt8186_efuse_pdata },
> > >        { .compatible = "mediatek,efuse", .data = &mtk_efuse_pdata },
> > >        {/* sentinel */},
> > >    };