Re: [PATCH 1/3] sched/fair: Remove unused task_numa_migrate return value

[Chuyi Zhou]

Hello Prateek,

在 2024/12/18 14:29, K Prateek Nayak 写道:
> Hello Chuyi,
>
> On 12/16/2024 5:53 PM, Chuyi Zhou wrote:
> > The return value of task_numa_migrate is unused, remove it.
> >
> > Signed-off-by: Chuyi Zhou <zhouchuyi@xxxxxxxxxxxxx>
>
> Feel free to include:
>
> Reviewed-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>
>
> If anyone cares for the history, initial NUMA Balancing implementation
> used the return value of task_numa_migrate() to retry NUMA Balancing in
> commit 6b9a7460b6ba ("sched/numa: Retry migration of tasks to CPU on a
> preferred node") however in the same series[1], Mel also included an
> optimization from Rik which retried NUMA Balancing periodically
> irrespective the return value from task_numa_migrate() in commit
> 2739d3eef3a9 ("sched/numa: Retry task_numa_migrate() periodically")
>
> [1] https://lore.kernel.org/all/1381141781-10992-34-git-send-email- 
> mgorman@xxxxxxx/

Thank you for providing the historical information! I will incorporate 
it into the next version.