Re: [PATCH V4] scsi: ufs: qcom: Enable UFS Shared ICE Feature

From: Ram Kumar Dwivedi
Date: Mon Dec 23 2024 - 08:32:35 EST




On 20-Dec-24 10:46 PM, Bart Van Assche wrote:
> On 12/20/24 2:06 AM, Ram Kumar Dwivedi wrote:
>> This function will be only called once during boot and "val" is a local variable, we don't see any advantage in making it static.
>> If you still recommend, i will add the static keyword in next patchset.
>
> The advantage of declaring the array static is that the array will be
> initialized at compile time instead of at runtime. Additionally, this
> will reduce stack utilization (assuming that the compiler does not
> optimize out the array entirely).
>
Hi Bart,

We have added "static" keyword in latest patch set.

Thanks,
Ram.

> Thanks,
>
> Bart.
>