Re: [PATCH v2 0/7] Add support for MAX7360

[Mathieu Dubois-Briand]

On Mon Dec 23, 2024 at 6:09 PM CET, Uwe Kleine-König wrote:
> Hello Mathieu,
>
> On Mon, Dec 23, 2024 at 06:05:39PM +0100, Uwe Kleine-König wrote:
> > On Mon, Dec 23, 2024 at 05:42:32PM +0100, Mathieu Dubois-Briand wrote:
> > > - Removing device tree subnodes for keypad, rotary encoder and pwm
> > >   functionalities.
> > 
> > How did you test the pwm? Just using sysfs? Without a node there is
> > hardly any other usage left, because you cannot pass the pwm to e.g. a
> > pwm-fan node. So it might be sensible to drop the nodes for keypad and
> > rotary encoder, but I think you better keep the pwm one.
>
> I think I was to quick here. It might just work ...
>
> Best regards
> Uwe

Hi Uwe,

I also had some doubt here, keeping the node might be bit more clear but
I thought you wanted me to drop it.

And yes, as you said, it does work. For reference, I test it using some
pwm-led:

pwm-leds {
	compatible = "pwm-leds";

	battery {
		label = "battery";
		pwms = <&max7360 0 2000000 0>;
		max-brightness = <128>;
		linux,default-trigger = "heartbeat";
	};
};

Where &max7360 is a reference to the root node (io-expander@38 in the
binding example).

Best regards,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com