Re: [RFC PATCH 06/15] x86/microcode: Update the Intel processor flag scan check
From: Sohil Mehta
Date: Mon Dec 23 2024 - 14:52:41 EST
On 12/21/2024 1:11 AM, Borislav Petkov wrote:
>>
>> - if (x86_model(sig->sig) >= 5 || x86_family(sig->sig) > 6) {
>> + /* TODO: Simplify this using a VFM check? */
>
> No TODOs. Take your time and do it right from the get-go please.
>
Sorry, this sneaked through. I was supposed to modify the comment before
sending it out. For this RFC, I was looking for suggestions since there
didn't seem a straight forward way to convert sig to VFM.
But as Dave mentioned in the other thread, maybe we don't need to redo
CPUID in the first place and this code can reuse cpu_data(). I'll
explore that path first.
Sohil