Re: [RFC PATCH 08/15] x86/cpu/intel: Replace early family 6 checks with VFM ones
From: Sohil Mehta
Date: Mon Dec 23 2024 - 15:15:51 EST
On 12/21/2024 7:57 AM, Dave Hansen wrote:
>> Isn't the order 'funny' as well.
>> I think it ends up being neither numeric or date order.
>> Increasing family order is probably best, but the headings for each
>> 'family' probably need to be a bit more descriptive (esp 15 - all P4
>> netburst).
>
> <shrug>
>
> They're already out of order because Quark is a weirdo and we didn't
> want to look at it all the time so it got stuck at the bottom. It's
> _fine_ when it's 99% family 6 plus 2 other weirdos.
>
> But it should probably get sorted at some point because it's going to be
> hard to find Quark and P4 if the order is
>
> fam 6,1
> fam 5
> fam 15
> fam 18
> fam 19
> fam 20
> ...
>
> But I think all that has to be done is to move Quark up to the top.
>
Patch 10/15 adds a few Family 5 defines. I'll move Family 5 to the top
along with that.