Re: [PATCH] dmaengine: idxd: Remove unused idxd_(un)register_bus_type

[Fenghua Yu]

On 12/21/24 06:16, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> idxd_register_bus_type() and idxd_unregister_bus_type() have been unused
> since 2021's
> commit d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver
> to standalone")
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>

> ---
>   drivers/dma/idxd/idxd.h  |  2 --
>   drivers/dma/idxd/sysfs.c | 10 ----------
>   2 files changed, 12 deletions(-)
>
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index d84e21daa991..ff33ebf08ee7 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -725,8 +725,6 @@ static inline void idxd_desc_complete(struct idxd_desc *desc,
>   				   &desc->txd, &status);
>   }
>   
> -int idxd_register_bus_type(void);
> -void idxd_unregister_bus_type(void);
>   int idxd_register_devices(struct idxd_device *idxd);
>   void idxd_unregister_devices(struct idxd_device *idxd);
>   void idxd_wqs_quiesce(struct idxd_device *idxd);
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index f706eae0e76b..6af493f6ba77 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -1979,13 +1979,3 @@ void idxd_unregister_devices(struct idxd_device *idxd)
>   		device_unregister(group_confdev(group));
>   	}
>   }
> -
> -int idxd_register_bus_type(void)
> -{
> -	return bus_register(&dsa_bus_type);
> -}
> -
> -void idxd_unregister_bus_type(void)
> -{
> -	bus_unregister(&dsa_bus_type);
> -}

Thanks.

-Fenghua