Re: [PATCH v2 4/6] clk: renesas: rzv2h: Switch MSTOP configuration to per-bit basis
From: Geert Uytterhoeven
Date: Tue Dec 24 2024 - 07:55:21 EST
Hi Prabhakar,
On Mon, Dec 23, 2024 at 6:37 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Refactor MSTOP handling to switch from group-based to per-bit
> configuration. Introduce atomic counters for each MSTOP bit and update
> enable/disable logic.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v1->v2
> - New patch
Thanks for your patch!
Early review comment: the big missing part in the patch description
is the answer to the "Why?"-question. So please elaborate.
No need to resend (for now).
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds