RE: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after dma_async_device_unregister

From: Peng Fan
Date: Tue Dec 24 2024 - 20:00:54 EST


> Subject: [PATCH V4 1/2] dmaengine: fsl-edma: cleanup chan after
> dma_async_device_unregister

Ping..

Thanks,
Peng.

>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> There is kernel dump when do module test:
> sysfs: cannot create duplicate filename
> /devices/platform/soc@0/44000000.bus/44000000.dma-
> controller/dma/dma0chan0
> __dma_async_device_channel_register+0x128/0x19c
> dma_async_device_register+0x150/0x454
> fsl_edma_probe+0x6cc/0x8a0
> platform_probe+0x68/0xc8
>
> fsl_edma_cleanup_vchan will unlink vchan.chan.device_node, while
> dma_async_device_unregister needs the link to do
> __dma_async_device_channel_unregister. So need move
> fsl_edma_cleanup_vchan after dma_async_device_unregister to make
> sure channel could be freed.
>
> So clean up chan after dma_async_device_unregister to address this.
>
> Fixes: 6f93b93b2a1b ("dmaengine: fsl-edma: kill the tasklets upon exit")
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---