Re: [PATCH] platform/x86: hp-wmi: mark 8A15 board for timed OMEN thermal profile

[Mingcong Bai]

Hi Ilpo,

Sorry for the late reply but your email fell through the cracks.

在 2024/12/24 03:15, Ilpo Järvinen 写道:
> On Mon, 23 Dec 2024, Mingcong Bai wrote:
>
> > From: xiaoxi404 <1577912515@xxxxxx>
> >
> > The HP OMEN 8 (2022), corresponding to a board ID of 8A15, supports OMEN
> > thermal profile and requires the timed profile quirk.
> >
> > Upon adding this ID to both the omen_thermal_profile_boards and
> > omen_timed_thermal_profile_boards, significant bump in performance can be
> > observed. For instance, SilverBench (https://silver.urih.com/) results
> > improved from ~56,000 to ~69,000, as a result of higher power draws (and
> > thus core frequencies) whilst under load:
> >
> > Package Power:
> >
> > - Before the patch: ~65W (dropping to about 55W under sustained load).
> > - After the patch: ~115W (dropping to about 105W under sustained load).
> >
> > Core Power:
> >
> > - Before: ~60W (ditto above).
> > - After: ~108W (ditto above).
> >
> > Add 8A15 to omen_thermal_profile_boards and
> > omen_timed_thermal_profile_boards to improve performance.
> >
> > Signed-off-by: xiaoxi404 <1577912515@xxxxxx>
> > Signed-off-by: Mingcong Bai <jeffbai@xxxxxxx>
>
> Hi,
>
> I wanted to apply this but the first signed-off-by line threw me off. It
> should contain person's name before the email address line like yours does
> (assuming the first signed-off-by is necessary in the first place, the
> patch itself looks quite trivial given it's just about adding one ID).

Understood, but that is how this person represents themselves online. If 
that is indeed a problem, I can consult them for how this should be handled.

Best Regards,
Mingcong Bai