Re: [PATCH v3 0/5] perf stat: Fix trailing comma when there is no metric unit

[Arnaldo Carvalho de Melo]

On Thu, Dec 12, 2024 at 12:01:00AM -0800, Ian Rogers wrote:
> On Tue, Dec 10, 2024 at 10:42 AM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > On Tue, Nov 12, 2024 at 04:00:40PM +0000, James Clark wrote:
> > > The first commit is failing on Arm and I think the fix should stop more
> > > trailing comma issues which keep happening.
> > >
> > > The second one I just noticed when looking at it. I don't feel strongly
> > > about it so not sure if we should do it or not, but seems like the empty
> > > metric-units exclusion from the JSON should be consistent if we're going
> > > to have it at all.
> > >
> > > Changes since v2:
> > >   * Do more documentation and tidyups around struct outstate
> >
> > Ian, have you had the chance of going over this series?
> 
> It looks good to me, I particularly appreciate the additional

Indeed.

> comments/documentation. Tested with sanitizers.
> 
> Tested-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks, applied to perf-tools-next,

- Arnaldo