[PATCH 0/4] hwmon: (oxp-sensors) Cleanup device type handling

From: tjakobi
Date: Thu Dec 26 2024 - 12:12:34 EST


From: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>

Hello,

this series tries to cleanup the handling of the various device types
in the oxp-sensors drivers. The current approach is error-prone
since it relies on ever-growing switch-statements, which are
present in multiple functions. Adding a single new device involves
touching a bunch of functions.

That this is problematic is already demonstrated by this bug in
the driver: While oxp_pwm_disable() handles the aya_neo_air_1s
model, the inverse function oxp_pwm_enable() does not handle the
model. This is obviously wrong and a result of the current design.

Introduce a different design with better separation of logic and
data. While at it, also fix some typos, wording and add a cache
for the PWM enable mode.

With best wishes,
Tobias

Tobias Jakobi (4):
hwmon: (oxp-sensors) Separate logic from device-specific data
hwmon: (oxp-sensors) Fix typos in documentation
hwmon: (oxp-sensors) Fix wording in code comment
hwmon: (oxp-sensors) Cache state of PWM enable mode

Documentation/hwmon/oxp-sensors.rst | 2 +-
drivers/hwmon/oxp-sensors.c | 576 +++++++++++++---------------
2 files changed, 275 insertions(+), 303 deletions(-)

--
2.45.2