Re: [PATCH v4 4/7] phy: exynos5-usbdrd: fix EDS distribution tuning (gs101)

[William McVicker]

On 12/06/2024, André Draszik wrote:
> This code's intention is to configure lane0 and lane2 tunings, but for
> lane2 there is a typo and it ends up tuning something else.
> 
> Fix the typo, as it doesn't appear to make sense to apply different
> tunings for lane0 vs lane2.
> 
> The same typo appears to exist in the bootloader, hence we restore the
> original value in the typo'd registers as well. This can be removed
> once / if the bootloader is updated.
> 
> Note that this is incorrect in the downstream driver as well - the
> values had been copied from there.
> 
> Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Tested-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>

Verified on my Pixel 6 Pro.

Tested-by: Will McVicker <willmcvicker@xxxxxxxxxx>

Thanks,
Will

<snip>