Re: [PATCH 01/20] alienware-wmi: Remove unnecessary check at module exit

[Armin Wolf]

Am 21.12.24 um 06:58 schrieb Kurt Borja:

> Module initialization fails if platform device fails to register so it's
> always not NULL at exit.

Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
>   drivers/platform/x86/dell/alienware-wmi.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
> index e95d22c7b60c..ed66720260ab 100644
> --- a/drivers/platform/x86/dell/alienware-wmi.c
> +++ b/drivers/platform/x86/dell/alienware-wmi.c
> @@ -1257,13 +1257,11 @@ module_init(alienware_wmi_init);
>
>   static void __exit alienware_wmi_exit(void)
>   {
> -	if (platform_device) {
> -		alienware_zone_exit(platform_device);
> -		remove_hdmi(platform_device);
> -		remove_thermal_profile();
> -		platform_device_unregister(platform_device);
> -		platform_driver_unregister(&platform_driver);
> -	}
> +	alienware_zone_exit(platform_device);
> +	remove_hdmi(platform_device);
> +	remove_thermal_profile();
> +	platform_device_unregister(platform_device);
> +	platform_driver_unregister(&platform_driver);
>   }
>
>   module_exit(alienware_wmi_exit);