Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox

[Krzysztof Kozlowski]

On Fri, Dec 20, 2024 at 01:07:54AM +0800, Jason-JH.Lin wrote:
>    2) GCE Subsys ID:
>    - Defined in the header file: `#define SUBSYS_1c00XXXX 3`
>    - Used in the Device Tree:
>    	`mediatek,gce-client-reg = <&gce SUBSYS_1c00XXXX 0x0000 0x1000>;`
>    - Parsed and used in the driver to configure subsys ID:
>      ```c
>      int cmdq_dev_get_client_reg(struct device *dev,
>      				 struct cmdq_client_reg *client_reg,
>      				 int idx)
>      {
>      	client_reg->subsys = (u8)spec.args[0];
>      	client_reg->offset = (u16)spec.args[1];
>      }
>      // GCE write the value to the register 0x1c000000 + 0x0000 + offset
>      cmdq_pkt_write(cmdq_handle, client_reg->subsys,
>      		    client_reg->offset + offset, value);

This is a proof that SUBSYS_1300XXXX is not a binding. Your driver does
not use it.

Drop all such things which are not used by drivers or explain why they
are needed to be in the binding - what do they bind.

I asked for this already, for exactly the same thing.


I did not check the rest, so next time I will choose any other random
define and if I do not find it explained nor used, I will question it.
Because you tend to apply pieces of review instead of really change your
code.

>      ```

Best regards,
Krzysztof