Re: [PATCH v2 1/2] dt-bindings: power: add power binding header for RK3562 SoC

[Krzysztof Kozlowski]

On Tue, Dec 24, 2024 at 05:39:19PM +0800, Kever Yang wrote:
> From: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
> 
> According to a description from TRM, add all the power domains.
> 
> Signed-off-by: Finley Xiao <finley.xiao@xxxxxxxxxxxxxx>
> Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> ---
> 
> Changes in v2:
> - rename to rockchip,rk3562-power.h
> - update the subject
> - use dual license
> 
>  .../dt-bindings/power/rockchip,rk3562-power.h | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)


No, where is the actual binding?

Your split of patches is not bisectable, illogical and not helping.
Bindings always go with the drivers.

>  create mode 100644 include/dt-bindings/power/rockchip,rk3562-power.h
> 
> diff --git a/include/dt-bindings/power/rockchip,rk3562-power.h b/include/dt-bindings/power/rockchip,rk3562-power.h
> new file mode 100644
> index 000000000000..d728c9ee908d
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rk3562-power.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */

And why not license requested by checkpatch?

Best regards,
Krzysztof