Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions

From: Karan Sanghavi
Date: Fri Dec 27 2024 - 05:01:23 EST


On Mon, Dec 23, 2024 at 01:43:09PM +0100, Markus Elfring wrote:
> >> Use signed data type for version handling
> >> in shmem_parse_opt_casefold()
>
> How do you think about to move this information into the summary phrase?
>
>
should i add more info to this? as i am still not able to understand
what i need to do here. Can you please suggest what changes are you
suggesting here.

>
> >> ---
> >> Coverity Message:
> >> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
> >> unsigned_compare: This less-than-zero comparison of an unsigned
> >> value is never true. version < 0U
>
>
> May such information become a part for the final change description?
>
ofcoure not, as per my understanding, text after '---' are not included
in the change descriptions. (Do correct me if i am wrong here) Thus no
need to worry for them getting added in the change log.

Thank you,
Karan.
> Regards,
> Markus