Re: [PATCH 1/2] arm64: dts: rockchip: Use "dma-noncoherent" in base RK3588 SoC dtsi
From: Marc Zyngier
Date: Fri Dec 27 2024 - 11:47:48 EST
On Fri, 27 Dec 2024 15:42:23 +0000,
Dragan Simic <dsimic@xxxxxxxxxxx> wrote:
>
> The preferred way to denote hardware with non-coherent DMA is to use the
> "dma-noncoherent" DT property, at both the GIC redistributor and the GIC ITS
> levels, [1] instead of relying on the compatibles to handle hardware errata,
> in this case the Rockchip 3588001 errata. [2]
>
> Let's have the preferred way employed in the base Rockchip RK3588 SoC dtsi,
> which also goes along with adding initial support for the Rockchip RK3582 SoC
> variant, with its separate compatible. [2][3]
>
> [1] Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
> [2] https://lore.kernel.org/linux-rockchip/86msgoozqa.wl-maz@xxxxxxxxxx/
> [3] https://lore.kernel.org/linux-rockchip/20241222030355.2246-4-naoki@xxxxxxxxx/
>
> Cc: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: FUKAUMI Naoki <naoki@xxxxxxxxx>
> Signed-off-by: Dragan Simic <dsimic@xxxxxxxxxxx>
Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
M.
--
Without deviation from the norm, progress is not possible.