Re: [PATCH 7/8] verification/dot2k: Auto patch current kernel source

[Gabriele Monaco]

Il 27 dicembre 2024 19:44:40 UTC, Steven Rostedt <rostedt@xxxxxxxxxxx> ha scritto:
>On Fri, 27 Dec 2024 15:47:51 +0100
>Gabriele Monaco <gmonaco@xxxxxxxxxx> wrote:
>
>> dot2k suggests a list of changes to the kernel tree while adding a
>> monitor: edit tracepoints header, Makefile, Kconfig and moving the
>> monitor folder. Those changes can be easily run automatically.
>> 
>> This patch adds a flag to dot2k to alter the kernel source.
>
>I'll pull in these patches for linux-next, but the above should be written
>as:
>
>  Add a flag to dot2k to alter the kernel source.
>
>I made the update. This is for future reference. Never use "This patch" or
>"This commit" in a change log.
>
>Thanks,
>
>-- Steve
>

Alright, thanks for the note and the fast reply!

Cheers,
Gabriele

>
>> 
>> The kernel source directory can be either assumed from the PWD, or from
>> the running kernel, if installed.
>> This feature works best if the kernel tree is a git repository, so that
>> its easier to make sure there are no unintended changes.
>> 
>> The main RV files (e.g. Makefile) have now a comment placeholder that
>> can be useful for manual editing (e.g. to know where to add new
>> monitors) and it is used by the script to append the required lines.
>> 
>> We also slightly adapt the file handling functions in dot2k: __open_file
>> is now called __read_file and also closes the file before returning the
>> content; __create_file is now a more general __write_file, we no longer
>> return on FileExistsError (not thrown while opening), a new
>> __create_file simply calls __write_file specifying the monitor folder in
>> the path.
>> 
>> Signed-off-by: Gabriele Monaco <gmonaco@xxxxxxxxxx>
>

Gabriele Monaco
Senior Software Engineer - Kernel Real Time
Red Hat

gmonaco@xxxxxxxxxx