[PATCH] lib: Fix return check in 842_compress.c

From: Tanya Agarwal
Date: Sat Dec 28 2024 - 02:43:02 EST


From: Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx>

Add missing error handling for add_repeat_template() return value.
Note that this error case is already properly handled later in other
add_repeat_template() function calls.

CID 1309755: (#1 of 1): Unused value (UNUSED_VALUE)
returned_value: Assigning value from add_repeat_template(p, repeat_count)
to ret here, but that stored value is overwritten before it can be used.

Coverity Link:
https://scan5.scan.coverity.com/#/project-view/63683/10063?selectedIssue=1309755

Signed-off-by: Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx>
---
lib/842/842_compress.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c
index c02baa4168e1..055356508d97 100644
--- a/lib/842/842_compress.c
+++ b/lib/842/842_compress.c
@@ -532,6 +532,8 @@ int sw842_compress(const u8 *in, unsigned int ilen,
}
if (repeat_count) {
ret = add_repeat_template(p, repeat_count);
+ if (ret)
+ return ret;
repeat_count = 0;
if (next == last) /* reached max repeat bits */
goto repeat;
--
2.39.5