Re: [PATCH] dt-bindings: phy: add rk3576 hdptx phy

[Krzysztof Kozlowski]

On 27/12/2024 11:46, Andy Yan wrote:
>>
>>> +              - rockchip,rk3576-hdptx-phy
>>
>> So that's just enum with previous entry... but you said compatible, yet
>> nothing is here. Test your patches - DTS will fail on this. Driver as
>> well (assuming you expressed properly compatibility).
> 
> Is this the right way to write it ？：
> 
> properties:
>    compatible:
> -    enum:
> -      - rockchip,rk3588-hdptx-phy
> +    oneOf:
> +      - enum:
> +          - rockchip,rk3588-hdptx-phy
> +      - items:
> +          - enum:
> +              - rockchip,rk3576-hdptx-phy
> +          - const: rockchip,rk3588-hdptx-phy

Yes, assuming they are compatible.

Best regards,
Krzysztof