Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

[Krzysztof Kozlowski]

On 27/12/2024 18:13, Pengyu Luo wrote:
> +
> +description:
> +  Different from other Qualcomm Snapdragon sc8180x sc8280xp based machines,
> +  the Huawei Matebook E Go tablets use embedded controllers while others
> +  use something called pmic glink which handles battery, UCSI, USB Type-C DP
> +  alt mode. Huawei one handles even more, like charging thresholds, FN lock,
> +  lid status, HPD events for the USB Type-C DP alt mode, etc.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - huawei,sc8180x-gaokun-ec
> +          - huawei,sc8280xp-gaokun-ec

sc8180x and sc8280xp are not products of Huawei, so you cannot combine
them. Use compatibles matching exactly your device, because I doubt any
of us has actual schematics or datasheet of that device.

> +      - const: huawei,gaokun-ec

How did you get the name?

> +
> +  reg:
> +    const: 0x38
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  connector:
> +    $ref: /schemas/connector/usb-connector.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c15 {

i2c

> +        clock-frequency = <400000>;
> +
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&i2c15_default>;

Drop all three above and test your bindings. This cannot work and test
will tell you what is missing.

> +
> +        embedded-controller@38 {
> +            compatible = "huawei,sc8280xp-gaokun-ec", ""huawei,gaokun-ec";
> +            reg = <0x38>;
> +
> +            interrupts-extended = <&tlmm 107 IRQ_TYPE_LEVEL_LOW>;
> +
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            connector@0 {

Test your bindings - you do not have node connector@0.



Best regards,
Krzysztof