Re: [for-next][PATCH 11/15] tracing: Switch trace_osnoise.c code over to use guard() and __free()
From: Markus Elfring
Date: Sat Dec 28 2024 - 09:08:33 EST
> The osnoise_hotplug_workfn() grabs two mutexes and cpu_read_lock(). It has
> various gotos to handle unlocking them. Switch them over to guard() and
> let the compiler worry about it.
>
> The osnoise_cpus_read() has a temporary mask_str allocated and there's
> some gotos to make sure it gets freed on error paths. Switch that over to
> __free() to let the compiler worry about it.
I would find it safer and cleaner to separate adjustments for these programming interfaces.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc4#n81
Will code transformation concerns be reconsidered any more?
Regards,
Markus