Re: [PATCH v3] dt-bindings: iio: light: opt3001: add compatible for opt3004
From: Krzysztof Kozlowski
Date: Sun Dec 29 2024 - 04:45:58 EST
On 28/12/2024 11:54, Hardevsinh Palaniya wrote:
>>> - Reverse the order of compatible string
>>>
>>> v1 -> v2:
>>>
>>> - Use fallback mechanism for the OPT3004.
>>> - Drop 2/2 patch from the patch series[1] as per feedback.
>>>
>>> Link[1]: https://lore.kernel.org/linux-iio/20241224061321.6048-1-hardevsinh.palaniya@xxxxxxxxxxxxxxxxx/T/#t
>>
>>
>> And where is any user of this, the DTS? We don't take bindings just
>> because there is such device out there.
>>
>> I looked and nothing:
>> https://lore.kernel.org/all/?q=ti%2Copt3004
>
> I added compatibility for the OPT3004 into the driver. However,
> based on Andy's feedback, it seems there might not be a need
> to include this directly in the driver.
> (Refer to Link [1] from the changelog.)
>
> we could follow a similar approach to how we handled the ADXL346,
> by just adding it to the bindings, since the ADXL346 is similar to the
> ADXL345.
Sure, I am not talking about this. I am looking for a user of the
binding. Where is one?
User is any piece of *upstream* project which uses the binding.
Best regards,
Krzysztof