Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol

[Lukas Wunner]

On Sat, Dec 28, 2024 at 12:21:58PM -0800, Lleyton Gray wrote:
> commit 71e49eccdca6 ("x86/efistub: Call Apple set_os protocol on dual GPU
> Intel Macs") calls the Apple set_os protocol, but only on T2 Macbook Pro
> models. This causes issues on other T2 models when an egpu is used.

How so?  The commit specifically constrains the quirk only to
affected dual GPU MacBook Pros.  So I don't quite see how this
would affect other T2 models?

And what kind of issues are you seeing?  Could you provide
specifics please?

> Add two options which allow force enabling or disabling usage of the
> protocol to fix.

We generally try to avoid command line options.  The kernel
should automatically determine whether to apply the quirk
or not.  So I think the proper solution is to amend the
quirk such that it's applied to additional models or not
applied under certain circumstances.

Thanks,

Lukas