Re: [PATCH v2] ALSA: ctxfi: Simplify dao_clear_{left,right}_input() functions
From: Kuan-Wei Chiu
Date: Mon Dec 30 2024 - 10:47:31 EST
Hi Ethan,
Thank you for your patch. However, there are a few issues:
On Mon, Dec 30, 2024 at 03:32:58PM +0000, Ethan Carter Edwards wrote:
> There was a lote of code duplication in the dao_clear_left_input() and
> dao_clear_right_input() functions. A new function, dao_clear_input(),
> was created and now the left and right functions call it instead of
> repeating themselves.
>
> Link: https://lore.kernel.org/lkml/NyKCr2VHK_xCQDwNxFKKx2LVd2d_AC2f2j4eAvnD9uRPtb50i2AruCLOp6mHxsGiyYJ0Tgd3Z50Oy1JTi5gPhjd2WQM2skrv7asp3fLl8HU=@ethancedwards.com/
>
Please move the Link: tag to the SoB area without an empty line.
> Signed-off-by: Ethan Carter Edwards <ethan@xxxxxxxxxxxxxxxxx>
> Co-developed-by: David Laight <david.laight.linux@xxxxxxxxx>
The Co-developed-by: tag should be immediately followed by the
co-author's Signed-off-by: tag. Additionally, the last Signed-off-by:
tag must always belong to the patch submitter.
See: https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
Regards,
Kuan-Wei