Re: [PATCH 2/2] arm64: dts: qcom: Add cpu scaling clock node

From: Konrad Dybcio
Date: Mon Dec 30 2024 - 11:43:03 EST


On 9.11.2024 1:00 AM, Dmitry Baryshkov wrote:
> On Fri, Nov 08, 2024 at 11:54:05AM +0530, Taniya Das wrote:
>> Add cpufreq-hw node to support cpu frequency scaling.
>
> CPU, not cpu.
> Also the prefix is incorrect for both patches.
>
>>
>> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
>> ---

[...]

>
> This doesn't follow the bindings, does it?
>
>> + reg = <0 0x18323000 0 0x1400>,
>> + <0 0x18325800 0 0x1400>;
>> + reg-names = "freq-domain0", "freq-domain1";
>> +
>> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GPLL0>;
>> + clock-names = "xo", "alternate";
>
> Are the DCVSH interrupts?

32/33 for silver/gold respectively

Konrad