Re: [PATCH v2 2/2] selftests: coredump: Add stackdump test

[Kees Cook]

On Mon, Dec 30, 2024 at 11:17:31AM +0100, Nam Cao wrote:
> Add a test which checks that the kstkesp field in /proc/pid/stat can be
> read for all threads of a coredumping process.
> 
> For full details including the motivation for this test and how it works,
> see the README file added by this commit.

This is great! One tiny nit below...

> +#define STACKDUMP_FILE "/tmp/kselftest_stackdump"

Please move this to the local directory (and have the Makefile and/or
test itself clean it up). (Or use mkstemp()) I don't want to have "well
known" filenames appearing in /tmp for selftests.

-Kees

-- 
Kees Cook