Re: [PATCH 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call

[Qi Zheng]

On 2024/12/31 01:53, Rik van Riel wrote:
> Every pv_ops.mmu.tlb_remove_table call ends up calling tlb_remove_table.
>
> Get rid of the indirection by simply calling tlb_remove_table directly,
> and not going through the paravirt function pointers.
>
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxxx>
> Suggested-by: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> ---
>   arch/x86/hyperv/mmu.c                 |  1 -
>   arch/x86/include/asm/paravirt.h       |  5 -----
>   arch/x86/include/asm/paravirt_types.h |  2 --
>   arch/x86/kernel/kvm.c                 |  1 -
>   arch/x86/kernel/paravirt.c            |  1 -
>   arch/x86/mm/pgtable.c                 | 16 ++++------------
>   arch/x86/xen/mmu_pv.c                 |  1 -
>   7 files changed, 4 insertions(+), 23 deletions(-)

This change looks good to me. Thanks!

In addition, since I also made relevant changes [1], there will be
conflict when our code is merged into the linux-next branch. Of course,
this is very easy to fix. ;)

[1]. 
https://lore.kernel.org/all/0287d442a973150b0e1019cc406e6322d148277a.1733305182.git.zhengqi.arch@xxxxxxxxxxxxx/
(This patch has been merged into the mm-unstable branch, and we can
also see it in the linux-next: 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=62e76fb4ff704945b5cf9411dda448fefb6618f9)

Thanks,
Qi