Re:Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support

[Andy Yan]

Hi Krzysztof,

At 2024-12-31 16:23:39, "Krzysztof Kozlowski" <krzk@xxxxxxxxxx> wrote:
>On Sun, Dec 29, 2024 at 06:49:38PM +0800, Andy Yan wrote:
>> 
>> 
>> Hi Krzysztof,
>> 
>> At 2024-12-29 18:13:39, "Krzysztof Kozlowski" <krzk@xxxxxxxxxx> wrote:
>> >On Sat, Dec 28, 2024 at 08:21:48PM +0800, Andy Yan wrote:
>> >> From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
>> >> 
>> >> Add vop found on rk3576, the main difference between rk3576 and the
>> >> previous vop is that each VP has its own interrupt line.
>> >> 
>> >> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
>> >> 
>> >> ---
>> >> 
>> >> Changes in v2:
>> >> - describe constraint SOC by SOC, as interrupts of rk3576 is very
>> >>   different from others
>> >> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
>> >> 
>> >> Changes in v1:
>> >> - ordered by soc name
>> >> - Add description for newly added interrupt
>> >> 
>> >>  .../display/rockchip/rockchip-vop2.yaml       | 70 +++++++++++++++----
>> >>  1 file changed, 56 insertions(+), 14 deletions(-)
>> >> 
>> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> index 2531726af306..f28cea4a6d82 100644
>> >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml
>> >> @@ -20,6 +20,7 @@ properties:
>> >>      enum:
>> >>        - rockchip,rk3566-vop
>> >>        - rockchip,rk3568-vop
>> >> +      - rockchip,rk3576-vop
>> >>        - rockchip,rk3588-vop
>> >>  
>> >>    reg:
>> >> @@ -37,10 +38,22 @@ properties:
>> >>        - const: gamma-lut
>> >>  
>> >>    interrupts:
>> >> -    maxItems: 1
>> >> -    description:
>> >> -      The VOP interrupt is shared by several interrupt sources, such as
>> >> -      frame start (VSYNC), line flag and other status interrupts.
>> >> +    minItems: 1
>> >> +    maxItems: 4
>> >> +    items:
>> >> +      - description:
>> >
>> >That's contradictory. min/max say 1-4, but here you list two interrupts.
>> 
>> There are 4 interrupts on rk3576, and the other SOC only have one.
>
>But you listed two interrupts, so where does the "two" come from?
>
>> I am sorry that I am not familiar with this schema language; I have read many
>> other YAML bindings these days and try to write it correctly.
>> 
>> Maybe I should not list the interrupts-names here(then list the interrupt-name by soc at allOf:  part),
>>  like the clocks handles in samsung,usb3-drd-phy.yaml  ?
>
>xxx-names are supposed to be fully synced with xxx, so something needs
>to be fixed here. You can of course remove interrupt-names *completely*
>(but not partially, because all properties must be defined in top-level).

Thanks for your explanation， I will send a new version later.

>
>Best regards,
>Krzysztof
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@xxxxxxxxxxxxxxxxxxx
>http://lists.infradead.org/mailman/listinfo/linux-rockchip