Re: [PATCH 1/1] soc: ti: PRUSS OCP configuration

[Christophe JAILLET]

Le 23/12/2024 à 14:55, Basharath Hussain Khaja a écrit :
> From: Roger Quadros <rogerq@xxxxxx>
>
> Updates OCP master port configuration to enable memory access outside
> of the PRU-ICSS subsystem.
>
> This set of changes configures PRUSS_SYSCFG.STANDBY_INIT bit either
> to enable or disable the OCP master ports (applicable only on SoCs
> using OCP interconnect like the OMAP family).
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> Signed-off-by: Parvathi Pudi <parvathi@xxxxxxxxxxx>
> Signed-off-by: Basharath Hussain Khaja <basharath@xxxxxxxxxxx>
> ---
>   drivers/soc/ti/pruss.c       | 77 +++++++++++++++++++++++++++++++++++-
>   include/linux/pruss_driver.h |  6 +++
>   2 files changed, 82 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
> index d7634bf5413a..a0e233da052c 100644
> --- a/drivers/soc/ti/pruss.c
> +++ b/drivers/soc/ti/pruss.c
> @@ -25,14 +25,19 @@
>   #include <linux/slab.h>
>   #include "pruss.h"
>   
> +#define SYSCFG_STANDBY_INIT	BIT(4)
> +#define SYSCFG_SUB_MWAIT_READY	BIT(5)

Hi,

Nitpick: #include <linux/bits.h>?

CJ