Re: [PATCH] drm/ssd130x: Set SPI .id_table to prevent an SPI core warning

[Dmitry Baryshkov]

On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote:
> Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes:
> 
> Hello Dmitry,
> 
> > On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote:

[...]

> >> Since the check is done even for built-in drivers, drop the condition to
> >> only define the ID table when the driver is built as a module. Finally,
> >> rename the variable to use the "_spi_id" convention used for ID tables.
> >> 
> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> >
> > Fixes: 74373977d2ca ("drm/solomon: Add SSD130x OLED displays SPI support")
> >
> 
> I was on the fence about adding a Fixes: tag due a) the issue being there
> from the beginning as you pointed out and b) the warning being harmless.
> 
> But I'll add it to v2 or just before pushing it to drm-misc-next.

Just before pushing is enough. dim b4-shazam can do that for you.

> 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> >
> 
> Thanks for your review!
> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
> 

-- 
With best wishes
Dmitry