Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes

[Karim Manaouil]

On Wed, Jan 01, 2025 at 05:20:01PM +0200, Nadav Amit wrote:
> 
> 
> On 01/01/2025 6:42, Rik van Riel wrote:
> > Fixed for the next version.
> 
> Thanks Rik,
> 
> Admittedly, I don't feel great about my overall last review - it mostly
> focused on style and common BKMs.
> 
> I still don't quite get the entire logic. To name one thing that I don't
> understand: why do we need broadcast_asid_list and the complicated games of
> syncing it with broadcast_asid_used. Why wouldn't broadcast_asid_used
> suffice?

If I uderstand correctly from Rik's patch, I think the list is needed to
save the flush for only when we run out of the ASID space (wrap around).
Without the list, whenever the ASID bit is cleared, you also have to flush
the TLBs.

> 
> 
> 

-- 
Best,
Karim
Edinburgh University