Re: [PATCH] netfilter: uapi: Merge xt_*.h/c and ipt_*.h which has same name.

[Florian Westphal]

egyszeregy@xxxxxxxxxxx <egyszeregy@xxxxxxxxxxx> wrote:
>  /* match info */
> -struct xt_dscp_info {
> +struct xt_dscp_match_info {

To add to what Jan already pointed out, such renames
break UAPI, please don't do this.

It could be done with compat ifdef'ry but I think its rather ugly,
better to keep all uapi structure names as-is.

>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Marc Boucher <marc@xxxxxxx>");
> -MODULE_DESCRIPTION("Xtables: TCP MSS match");
> +MODULE_DESCRIPTION("Xtables: TCP Maximum Segment Size (MSS) adjustment/match");
>  MODULE_ALIAS("ipt_tcpmss");
>  MODULE_ALIAS("ip6t_tcpmss");
> +MODULE_ALIAS("ipt_TCPMSS");
> +MODULE_ALIAS("ip6t_TCPMSS");

I think you should add MODULE_ALIAS("xt_TCPMSS") just in case, same
for all other merged (== 'removed') module names, to the respective
match (preserved) modules.