Re: [PATCH 5.4~6.6] MIPS: Probe toolchain support of -msym32
From: Maciej W. Rozycki
Date: Thu Jan 02 2025 - 01:08:03 EST
On Tue, 24 Dec 2024, WangYuli wrote:
> From: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
>
> [ Upstream commit 18ca63a2e23c5e170d2d7552b64b1f5ad019cd9b ]
>
> msym32 is not supported by LLVM toolchain.
> Workaround by probe toolchain support of msym32 for KBUILD_SYM32
> feature.
Doesn't this reintroduce the failure fixed with commit a79a404e6c22
("MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression")?
If this call to `cc-option-yn' does need to be made here, then this whole
stuff has to be wrapped into a `need-compiler' check, see the discussion:
<https://lore.kernel.org/r/alpine.DEB.2.21.2307180025120.62448@xxxxxxxxxxxxxxxxx/>
and the other patches in the series.
Maciej