Re: [PATCH v7 1/4] x86/smp: Allow calling mwait_play_dead with an arbitrary hint

From: Patryk Wlazlyn
Date: Thu Jan 02 2025 - 04:50:51 EST


>>> And honestly I'm wondering why adding a parameter to mwait_play_dead()
>>> is better than introducing mwait_play_dead_with_hint(), in analogy
>>> with the existing mwait_idle_with_hints()?

Well.. Maybe that wasn't that good of an idea. I've given the rationale
in the 0/4:

> Changes since v6:
>  * Renamed mwait_play_dead to mwait_play_dead_cpuid_hint in 1/1, so that
>    mwait_play_dead name can be reused for the function that takes the
>    MWAIT hint as an argument. This leaves the comments around the
>    smpboot.c file that reference the old mwait_play_dead() unchanged.

It makes the patches simpler, in a sense that I don't have to update the
comments each patch when moving things around and renaming.