Re: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

[Christophe JAILLET]

Le 01/01/2025 à 16:39, Alexander Usyskin a écrit :
> In intel-dg, there is no access to the spi controller,
> the information is extracted from the descriptor region.
>
> CC: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Acked-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Co-developed-by: Tomas Winkler <tomasw@xxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomasw@xxxxxxxxx>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>

...

> @@ -89,6 +281,13 @@ static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev,
>   		goto err;
>   	}
>   
> +	ret = intel_dg_nvm_init(nvm, device);
> +	if (ret < 0) {
> +		dev_err(device, "cannot initialize nvm\n");
> +		ret = -ENODEV;

Why setting to -ENODEV?

> +		goto err;
> +	}
> +
>   	dev_set_drvdata(&aux_dev->dev, nvm);
>   
>   	return 0;