Re: [PATCH v3] mm: add build-time option for hotplug memory default online type

[David Hildenbrand]

On 22.12.24 06:03, Gregory Price wrote:
> On Sat, Dec 21, 2024 at 04:30:21PM +0100, David Hildenbrand wrote:
> > > -config MEMORY_HOTPLUG_DEFAULT_ONLINE
> > > -	bool "Online the newly added memory blocks by default"
> > > -	depends on MEMORY_HOTPLUG
> > > +choice
> > > +	prompt "Memory Hotplug Default Online Type"
> > > +	default MHP_DEFAULT_ONLINE_TYPE_OFFLINE
> > >    	help
> > > +	  Default memory type for driver managed hotplug memory.
> >
> > We should call it "hotplugged memory" consistently, which it is from a pure
> > core-mm perspective ("add memory").
> >
> > "Driver managed" reminds too much about add_memory_driver_managed(), which
> > is only one case. Maybe just drop the "e.g., page tables" from the examples
> > below.
>
> I suppose it's accurate that this also affects VM-hotplugged memory,
> which may not necessarily be "driver managed" in that regard. So it's
> more accurate to just say "hotplugged memory" - although even that's not
> quite completely accurate according to the definition in the docs.
>
> Either way, will change it to "hotplugged memory".

The "really correct" thing might be "hot-added memory blocks", because 
that's what it is from a Linux MM POV.

Not sure though, if that will be particularly easier to grasp for end users.

--
Cheers,

David / dhildenb