Re: [PATCH v2] netfilter: uapi: Merge xt_*.h/c and ipt_*.h which has same name.

[Andrew Lunn]

On Thu, Jan 02, 2025 at 06:21:15PM +0100, egyszeregy@xxxxxxxxxxx wrote:
> From: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>
> 
> Merge and refactoring xt_*.h, xt_*.c and ipt_*.h files which has the same
> name in upper and lower case format. Combining these modules should provide
> some decent memory savings.

Numbers please. We don't normally accept optimisations without some
form of benchmark showing there is an improvement.
 
> The goal is to fix Linux repository for case-insensitive filesystem,
> to able to clone it and editable on any operating systems.

This needs a much stronger argument, since as i already pointed out,
how many case-insenstive file systems are still in use? Please give
real world examples of why this matters.

>  delete mode 100644 include/uapi/linux/netfilter/xt_CONNMARK.h
>  delete mode 100644 include/uapi/linux/netfilter/xt_DSCP.h
>  delete mode 100644 include/uapi/linux/netfilter/xt_MARK.h
>  delete mode 100644 include/uapi/linux/netfilter/xt_RATEEST.h
>  delete mode 100644 include/uapi/linux/netfilter/xt_TCPMSS.h
>  delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_ECN.h
>  delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_TTL.h
>  delete mode 100644 include/uapi/linux/netfilter_ipv6/ip6t_HL.h

How did you verify that there is no user space code using these
includes?

We take ABI very seriously. You cannot break user space code.

    Andrew

---
pw-bot: cr