Re: [PATCH 2/3] dt-bindings: clock: xilinx: Convert VCU bindings to dtschema

From: Krzysztof Kozlowski
Date: Thu Jan 02 2025 - 13:26:18 EST


On 02/01/2025 17:36, Rohit Visavalia wrote:
> Convert AMD (Xilinx) VCU bindings to yaml format.
>


...

> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - xlnx,vcu
> + - xlnx,vcu-logicoreip-1.0
> +
> + reg:
> + description:
> + The base offset and size of the VCU_PL_SLCR register space.

Drop description, redundant.

> + minItems: 1

There is no code like this. maxItems instead. Please use example-schema
or other recently reviewed bindings as starting point.

> +
> + clocks:
> + description: List of clock specifiers

Drop description.

> + items:
> + - description: pll ref clocksource
> + - description: aclk

Original binding said different order. Mention change in commit msg with
explanation why.

Best regards,
Krzysztof