Re: [PATCH v2 1/3] dt-bindings: gpio: fairchild,74hc595: Add On Semi MC74HC595A compat

From: Rob Herring
Date: Thu Jan 02 2025 - 13:37:02 EST


On Tue, Dec 24, 2024 at 09:02:10AM +0100, J. Neuschäfer wrote:
> The On Semi MC74HC595A/MC74HCT595A is another part that is compatible with
> the Fairchild MM74HC595. This patch adds it to the DT binding.

To make the binding match what you say here, what you really should have
is:

compatible = "onnn,74hc595a", "fairchild,74hc595";

And then no driver change is needed (until you have some difference you
want to handle).

>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx>
> ---
>
> v2:
> - Add Linus Walleij's R-b
> ---
> Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index e8bc9f018edb1253d700945f006e19598efb299a..629cf9b2ab8e4a63fbe17f56792a46d2066d40c3 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - fairchild,74hc595
> - nxp,74lvc594
> + - onnn,74hc595a
>
> reg:
> maxItems: 1
>
> --
> 2.45.2
>